DIGEST-MD5 fails with ejabberd

[MattJ]

LOG: SENT: <auth mechanism="DIGEST-MD5" xmlns="urn:ietf:params:xml:ns:xmpp-sasl"/>
LOG: RECV: <challenge xmlns="urn:ietf:params:xml:ns:xmpp-sasl">bm9uY2U9IjI5NjAzMDU1NzYiLHFvcD0iYXV0aCIsY2hhcnNldD11dGYtOCxhbGdvcml0aG09bWQ1LXNlc3M=</challenge>
LOG: handle digest-md5 (challenge) called for challenge
LOG: couldn't retrieve value for 'realm'
LOG: SENT: <response xmlns="urn:ietf:params:xml:ns:xmpp-sasl">dXNlcm5hbWU9ImJvdCIscmVhbG09IiIiIixub25jZT0iMjk2MDMwNTU3Iixjbm9uY2U9IjAwREVBREJFRUYwMCIsbmM9MDAwMDAwMDEscW9wPWF1dGgsZGlnZXN0LXVyaT0ieG1wcC9tYXR0aGV3d2lsZC5jby51ayIscmVzcG9uc2U9OTg0ZTI2YjAxYjhiNzNmMDM5M2E1N2I1ZjdiMDM5YzksY2hhcnNldD11dGYtOA==</response>
LOG: RECV: <failure xmlns="urn:ietf:params:xml:ns:xmpp-sasl"><not-authorized/></failure>
LOG: handle digest-md5 (rspauth) called for failure
LOG: handle digest-md5 (default) called for failure
LOG: SASL DIGEST-MD5 auth failed!

[MattJ]

Possibly related to:  https://support.process-one.net/browse/EJAB-304

[jack]

Turns out this was an off by 1 string error in sasl.c:_parse_digest_challenge() coupled with not sending a default realm when the server doesn't supply one. Both of these issues are now fixed as of r503.